Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure a default value is set for options.filename #81

Closed
wants to merge 1 commit into from
Closed

Ensure a default value is set for options.filename #81

wants to merge 1 commit into from

Conversation

nkoterba
Copy link

Starting with Node v6+, path.dirname will not accept undefined inputs. Use the Node global variable __filename as a default value if filename is not passed in in the configuration object to node-browser-resolve-call.

@nkoterba
Ensure a default value is set for options.filename
a9ee016 
Starting with Node v6+, path.dirname will **not** accept undefined inputs.  Use the Node global variable `__filename` as a default value if `filename` is not passed in in the configuration object to node-browser-resolve-call.
This was referenced May 24, 2016
Merged
Closed
@goto-bus-stop
Copy link
Member

Thanks for the PR! This was eventually fixed by #80.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkoterba @goto-bus-stop